ci: update contribution information #8367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Aug 16, 2022
Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Closed
|
🚀 PR was released in |
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
* ci: update contribution information * Update CONTRIBUTING.md Co-authored-by: Dominik Moritz <domoritz@gmail.com> * fix: remove double dot * chore: remove line from PR template * ci: add first-interaction message * chore: readd workflow dispatch Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, after trying out #8363, #8365, and #8366, along with some ideas on my personal fork, I've come to the conclusion that switching the
Format, Schema, and ExamplesCI to be onpushrather than onpull_requestis the best solution. The reason for this decision is the complexity between running the CI and committing changes on a target repository versus committing the changes to the PR branch. This would involve complex resolutions such as possiblypull_request_target, which has security implications.Therefore, this PR changes the contribution workflow so
checkwill occur within the fork repository rather than on PR. We can add another CI to validate that the action ran successfully as well.📦 Published PR as canary version:
5.5.1--canary.8367.dd8fa44.0✨ Test out this PR locally via:
npm install vega-lite@5.5.1--canary.8367.dd8fa44.0 # or yarn add vega-lite@5.5.1--canary.8367.dd8fa44.0