Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support template literals as types. #1171

Merged
merged 3 commits into from Mar 20, 2022
Merged

feat: support template literals as types. #1171

merged 3 commits into from Mar 20, 2022

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Mar 20, 2022 •
edited by github-actions bot

This PR is to add support for Template Literals.

See: TypeScript: Documentation - Template Literal Types

I'll add support later for Intrinsic String Manipulation Types

Version

Published prerelease version: v0.98.1-next.2

Changelog

馃帀 This release contains work from new contributors! 馃帀

Thanks for all your work!

鉂わ笍 Jason Dent (@Jason3S)

鉂わ笍 Remi Cattiau (@loopingz)

鉂わ笍 Hadrien Milano (@hmil)

馃殌 Enhancement

  • feat: support template literals as types. #1171 (@Jason3S)
  • feat: move private to protected to allow extending behavior #1161 (@loopingz)
  • feat: add support for never type #1154 (@hmil)

馃敥 Dependency Updates

Authors: 4

@domoritz domoritz changed the title feat: Support template literals as types. feat: support template literals as types. Mar 20, 2022
domoritz
domoritz approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I just added some small comments to make the code more readable but otherwise this looks great.

src/NodeParser/StringTemplateLiteralNodeParser.ts Outdated Show resolved Hide resolved
src/NodeParser/StringTemplateLiteralNodeParser.ts Outdated Show resolved Hide resolved
@domoritz domoritz merged commit 642022c into vega:next Mar 20, 2022
@domoritz
Copy link
Member

Thank you

@github-actions
Copy link

馃殌 PR was released in v0.98.1-next.2 馃殌

@github-actions github-actions bot mentioned this pull request Mar 21, 2022
Merged
@Jason3S Jason3S deleted the template-literals branch March 21, 2022 16:51
@hydrosquall hydrosquall mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jason3S @domoritz