Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --minify option (#1120) #1121

Merged
merged 8 commits into from Feb 11, 2022
Merged

feat: --minify option (#1120) #1121

merged 8 commits into from Feb 11, 2022

Conversation

arthurfiorette
Copy link
Contributor

@arthurfiorette arthurfiorette commented Feb 9, 2022 •
edited by github-actions bot

Fixes #1120

Version

Published prerelease version: v0.98.0-next.0

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ Arthur Fiorette (@arthurfiorette)

❤️ Mark Sheinkman (@MarkSheinkman)

❤️ null@chimurai

❤️ Kari Lavikka (@tuner)

🚀 Enhancement

🐛 Bug Fix

🔩 Dependency Updates

Authors: 7

@arthurfiorette
Copy link
Contributor Author

@domoritz, this is it!

@domoritz domoritz enabled auto-merge (squash) February 9, 2022 23:02
@domoritz
Copy link
Member

Please fix the tests

@arthurfiorette
Copy link
Contributor Author

arthurfiorette commented Feb 10, 2022 •
edited

Are that tests broken because of my commit?

@arthurfiorette
Copy link
Contributor Author

Some of them. I forgot that i need the binary built before running the tests.

Should i just add an npm run build in the github CI before the test command or what?

@domoritz
Copy link
Member

We already do in

ts-json-schema-generator/.github/workflows/test.yml

Line 36 in dd13747

run: yarn build
, no?

@arthurfiorette
Copy link
Contributor Author

Oh, i meant the npm link command.

auto-merge was automatically disabled February 10, 2022 18:05

Head branch was pushed to by a user without write access

@domoritz
Copy link
Member

Why do we need to link? Can't we call the correct file my path?

@arthurfiorette
Copy link
Contributor Author

Well, maybe. On my computer it needs chmod before it works, so I thought a link would be better.

@arthurfiorette
Copy link
Contributor Author

Ha, it didn't work because it is calling jest directly, not the npm test script.

@domoritz
Copy link
Member

domoritz commented Feb 10, 2022 •
edited

On my computer it needs chmod before it works, so I thought a link would be better.

use node ... and then you don't need the chmod.

I don't like to link without the user knowing that we are doing it. It could cause problems if people have multiple clones.

@arthurfiorette
Copy link
Contributor Author

It didn't work on windows... Do you know why?

@domoritz
Copy link
Member

No. I don't use windows.

domoritz
domoritz approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the docs at https://github.com/vega/ts-json-schema-generator#options.

@arthurfiorette
Copy link
Contributor Author

Anything more?

@domoritz domoritz merged commit d37fca8 into vega:next Feb 11, 2022
@domoritz
Copy link
Member

Thank you

@github-actions github-actions bot mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to minify the output.
2 participants
@arthurfiorette @domoritz