fix: crash on a recursive interface with an intersection type #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This doesn't by any chance also fix #1029? |
|
Doesn't seem to have effect on that. I just tested. The problem there is on the parser side (?) but this was in a formatter. |
|
Thanks for checking. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1038
IntersectionTypeFormatterwas doing some premature culling on the child types, which may have been a reasonable optimization previously. However,RemoveUnreachable.ts, which was introduced later as a post-processing step, seems to do the pruning properly, making the optimization in the formatter unnecessary.This doesn't seem to cause performance regressions. Running the test suite took ~270s before and after the fix.
The test case fails on
nextbranch, passes on this.