chore: simplify workflow setup #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fetch unshallow with git checkout config
hydrosquall
force-pushed
the
feature/simplify-workflow-config
branch
from
b6f3ead
to
7266c79
Compare
|
This had a bug, it configured the wrong action, leading to errors like https://github.com/vega/ts-json-schema-generator/runs/4360752556?check_suite_focus=true . Fixed in #1045 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
git fetch's--unshallowwith configuration for the GithubcheckoutactionBackground
https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches
https://github.com/actions/checkout/blob/ec3a7ce113134d7a93b817d10a8272cb61118579/src/git-command-manager.ts#L180-L188
📦 Published PR as canary version:
0.97.1--canary.1039.7266c79.0✨ Test out this PR locally via:
npm install ts-json-schema-generator@0.97.1--canary.1039.7266c79.0 # or yarn add ts-json-schema-generator@0.97.1--canary.1039.7266c79.0