refactor: Use Parameter class directly in type hints instead of _Parameter protocol #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TYPE_CHECKING block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I was wrong in #3208 (comment) which is nice in this case :) We can use the
Parameterclass directly in type hints without running into circular imports thanks totyping.TYPE_CHECKING. See https://mypy.readthedocs.io/en/stable/runtime_troubles.html#import-cycles for more details but in summary, type checkers can be much more flexible how they import stuff as they don't run actual code so they can also deal with circular imports.There is no impact for users except that instead of
_Parameteras type hints:they now see the less confusing
Parameter: