Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't error when embed_options are None #3376

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: Don't error when embed_options are None #3376

merged 2 commits into from
Mar 22, 2024

Conversation

jonmmease
Copy link
Contributor

joelostblom
joelostblom approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a changelog entry and then merge?

@jonmmease jonmmease merged commit b1b9dba into main Mar 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelostblom joelostblom joelostblom approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonmmease @joelostblom