Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method-based attribute setting #2795

Merged
merged 19 commits into from
Jan 3, 2023
Merged

Add method-based attribute setting #2795

merged 19 commits into from
Jan 3, 2023

Commits on Jan 2, 2023

  1. Add method based syntax from #1629 to v5

    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    73c123f View commit details
    Browse the repository at this point in the history

  2. Add correct function signatures and docstrings, and initial autocompl… 

    …etion parameter support
    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    40ef6cb View commit details
    Browse the repository at this point in the history

  3. Add general param info to docstrings and pass through adding the help… 

    …er class docstring when not appropriate
    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    77a0210 View commit details
    Browse the repository at this point in the history

  4. Deal with docstring missing "Attributes" tag

    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    d33e275 View commit details
    Browse the repository at this point in the history

  5. Fix black formatting

    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    3fa8e6e View commit details
    Browse the repository at this point in the history

  6. Fix black formatting

    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    e7c8341 View commit details
    Browse the repository at this point in the history

  7. Update relative imports syntax

    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    43eeb22 View commit details
    Browse the repository at this point in the history

  8. Only generate new schema for the latest version of vega lite to avoid… 

    … backported changes that we do not test on older versions
    @joelostblom @ChristopherDavisUCI
    joelostblom authored and ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    213dcfe View commit details
    Browse the repository at this point in the history

  9. Type hints for tab completion

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    598baa8 View commit details
    Browse the repository at this point in the history

  10. Fix NoneType notation

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    184925d View commit details
    Browse the repository at this point in the history

  11. Replace Type[None] with None

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    33bc79b View commit details
    Browse the repository at this point in the history

  12. Basic documentation for attribute setter methods

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0b9ce4c View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: Stefan Binder <binder_stefan@outlook.com>
    @ChristopherDavisUCI @binste
    ChristopherDavisUCI and binste committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    733a8a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. define test_examples for both syntax

    @mattijn
    mattijn committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    94e2162 View commit details
    Browse the repository at this point in the history

  2. renaming iter_examples for methods syntax

    @mattijn
    mattijn committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    d448de2 View commit details
    Browse the repository at this point in the history

  3. add test examples using methods syntax

    @mattijn
    mattijn committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    72f7484 View commit details
    Browse the repository at this point in the history

  4. improve comments

    @mattijn
    mattijn committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    09e5000 View commit details
    Browse the repository at this point in the history

  5. exclude method examples dir from flake8 and black

    @mattijn
    mattijn committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    e3c7d7c View commit details
    Browse the repository at this point in the history

  6. include commit credits original prototype: #1629 

    Co-authored-by: Jake VanderPlas <781659+jakevdp@users.noreply.github.com>
    @mattijn @jakevdp
    mattijn and jakevdp committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    13cf86f View commit details
    Browse the repository at this point in the history