Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs on Aggregate Transforms #2645 #2654

Closed
wants to merge 12 commits into from
Closed

Improve docs on Aggregate Transforms #2645 #2654

wants to merge 12 commits into from

Conversation

tempdata73
Copy link
Contributor

@tempdata73 tempdata73 commented Jul 10, 2022

So this is what I've worked on with respect to #2645. A couple of notes:

  • I messed up my commits and branches, so the first two are just noise and won't affect the repo in any way whatsoever.
  • Similar to the previous point, I merged the add-argmax-example branch with this one, and so it appears that I want to add an example that's already been added in another pull request I made. My guess: it's because that hasn't been merged yet.
  • I didn't use vl's example of using argmax on the movies dataset because this whole page uses the cars dataset as a guide. I felt like using the former would break the flow of thought. Nonetheless, I can happily incorporate it if you guys prefer that one.

I hope this is what you're looking for, but if it isn't please tell me and I'll try to fix it right away.

@joelostblom
Copy link
Contributor

@tempdata73 I think the changes you suggested here look good and I am not sure why the PR was closed. I can reopen it but maybe you want to create a new one based on the latest main branch and remove the unnecessary commits you mentioned?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants