Added argmax example #2653
Merged
Added argmax example #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed y axis labeling
joelostblom
requested changes
Jul 9, 2022
There was a problem hiding this comment.
Thanks for this PR! I added a few minor comments. For your question, I think it makes sense to keep this example in the gallery and move the table with all the possible aggregations to the aggregation transform page instead of having it under the encoding page.
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
joelostblom
approved these changes
Jul 9, 2022
|
This is ready for merge when the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicated this example from vega-lite's site.
The motivation for this is #2645, however I don't know whether to