Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Bump down zstd-sys from 2.0.10 to 2.0.9 #20369

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Apr 24, 2024

To fix a WASM build issue reported in #20325 (comment). We can upgrade again once gyscos/zstd-rs#274 is
merged and released (or gyscos/zstd-rs#271 is otherwise fixed).

Also add a test that builds the playground to catch this sort of regression in the future.

To fix a WASM build issue. We can upgrade again once gyscos/zstd-rs#274 is
merged and released (or gyscos/zstd-rs#271 is otherwise fixed).

Also add a test that builds the playground to catch this sort of regression in the future.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
This reverts commit 0599d60.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Apr 24, 2024
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Apr 24, 2024
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Apr 25, 2024

Datadog Report

Branch report: jszwedko/bump-down-zstd
Commit report: 24ded66
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.5s Wall Time

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko added this pull request to the merge queue Apr 25, 2024
Copy link

Regression Detector Results

Run ID: 7e00a89c-deeb-4127-84cb-09dc64039f5f
Baseline: b025ba7
Comparison: e4e0ea5
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +5.16 [+5.03, +5.29]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +5.16 [+5.03, +5.29]
socket_to_socket_blackhole ingress throughput +2.81 [+2.73, +2.89]
syslog_regex_logs2metric_ddmetrics ingress throughput +1.19 [+1.01, +1.38]
http_text_to_http_json ingress throughput +1.17 [+1.02, +1.32]
datadog_agent_remap_datadog_logs ingress throughput +0.94 [+0.84, +1.05]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.56 [+0.46, +0.65]
fluent_elasticsearch ingress throughput +0.33 [-0.15, +0.80]
http_to_s3 ingress throughput +0.26 [-0.02, +0.54]
file_to_blackhole egress throughput +0.19 [-2.33, +2.71]
http_to_http_noack ingress throughput +0.17 [+0.07, +0.26]
http_to_http_json ingress throughput +0.05 [-0.03, +0.13]
otlp_grpc_to_blackhole ingress throughput +0.03 [-0.05, +0.12]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.08]
enterprise_http_to_http ingress throughput -0.09 [-0.17, -0.02]
http_to_http_acks ingress throughput -0.16 [-1.52, +1.20]
datadog_agent_remap_blackhole_acks ingress throughput -0.27 [-0.38, -0.17]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.30 [-0.45, -0.14]
datadog_agent_remap_blackhole ingress throughput -0.33 [-0.46, -0.21]
http_elasticsearch ingress throughput -0.35 [-0.42, -0.27]
syslog_log2metric_humio_metrics ingress throughput -0.46 [-0.61, -0.30]
syslog_humio_logs ingress throughput -0.52 [-0.64, -0.40]
splunk_hec_route_s3 ingress throughput -0.58 [-1.05, -0.12]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.67 [-0.83, -0.52]
syslog_loki ingress throughput -2.07 [-2.12, -2.03]
syslog_splunk_hec_logs ingress throughput -2.92 [-3.00, -2.85]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit e4e0ea5 Apr 25, 2024
50 checks passed
@jszwedko jszwedko deleted the jszwedko/bump-down-zstd branch April 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants