New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(regex_parser transform): Add support for nested field names #1967
Conversation
The upstream regex crate only supports alpha-numeric characters plus underscore in group names. Our fork adds support for field notation (period and square braces) in the `extend-group-names` branch. Use this branch until upstream supports more characters in group names. Signed-off-by: Bruce Guenter <bruce@timber.io>
Signed-off-by: Bruce Guenter <bruce@timber.io>
I have two questions:
|
|
And just noting. I would like to standardize around a field access syntax for consistency. If we're baking this into the regex crate, as well as other parts of Vector, it makes sense to document this somewhere and/or centralize parsing this format. |
@binarylogic
My concern is that subsequent changes, even with the submodule approach, would require coordinated effort between multiple repositories, while putting the full source to Vector's repository would allow to bundle each subsequent change into a single PR. |
From planning Option 1Given the caveats of maintaining a fork of the regex crate we've decided to add an option to place fields into a namespace, similar to the
Option 2Implement special encoding of |
Closing this due to discussion on the main issue |
Closes #1812