Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes_logs): Compile kube-rs with openssl #13038

Merged

Conversation

jaysonsantos
Copy link
Contributor

This is to avoid breaking kubernetes_source inside clusters with k3s.
For more info check the issue kube-rs/kube#805

This fixes #12989

This is to avoid breaking kubernetes_source inside clusters with k3s.
For more info check the issue kube-rs/kube#805
@bits-bot
Copy link

bits-bot commented Jun 8, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 7242254
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/62a0d1f90220080008961ae0

@spencergilbert spencergilbert self-assigned this Jun 8, 2022
@spencergilbert spencergilbert added ci-condition: k8s e2e all targets Run Kubernetes E2E test suite for all targets (instead of just the essential subset) ci-condition: k8s e2e tests enable Run Kubernetes E2E test suite for this PR labels Jun 8, 2022
Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@spencergilbert spencergilbert self-requested a review June 8, 2022 17:07
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaysonsantos ! The e2e k8s tests look good.

@spencergilbert spencergilbert enabled auto-merge (squash) June 8, 2022 19:32
@spencergilbert spencergilbert merged commit d462f61 into vectordotdev:master Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Soak Test Results

Baseline: 1ba91c9
Comparison: 7242254
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_loki 498.37KiB 3.2 100.00% 15.19MiB 464.78KiB 9.47KiB 0 0.0298675 15.68MiB 158.01KiB 3.23KiB 0 0.00983913 False False
splunk_hec_route_s3 312.84KiB 1.53 100.00% 20.02MiB 2.06MiB 43.15KiB 0 0.103072 20.33MiB 2.05MiB 42.84KiB 0 0.100792 False False
datadog_agent_remap_blackhole_acks 727.45KiB 1.03 99.99% 69.11MiB 7.02MiB 146.28KiB 0 0.101498 69.82MiB 5.21MiB 108.97KiB 0 0.0746717 False False
socket_to_socket_blackhole 106.49KiB 0.76 100.00% 13.74MiB 504.34KiB 10.27KiB 0 0.0358328 13.85MiB 487.98KiB 9.95KiB 0 0.0344102 False False
http_to_http_noack 87.26KiB 0.36 100.00% 23.76MiB 1018.02KiB 20.74KiB 0 0.0418294 23.85MiB 247.46KiB 5.05KiB 0 0.0101318 False False
fluent_elasticsearch 16.8KiB 0.02 92.51% 79.46MiB 465.91KiB 9.37KiB 0 0.00572512 79.47MiB 53.04KiB 1.07KiB 0 0.000651639 False False
splunk_hec_to_splunk_hec_logs_acks 3.02KiB 0.01 10.68% 23.76MiB 794.07KiB 16.15KiB 0 0.0326302 23.76MiB 768.69KiB 15.64KiB 0 0.031583 False False
http_to_http_json 2.4KiB 0.01 18.72% 23.84MiB 348.23KiB 7.11KiB 0 0.0142613 23.84MiB 354.28KiB 7.23KiB 0 0.0145078 False False
splunk_hec_to_splunk_hec_logs_noack -1.85KiB -0.01 15.01% 23.84MiB 335.91KiB 6.88KiB 0 0.013758 23.84MiB 341.17KiB 6.99KiB 0 0.0139744 False False
splunk_hec_indexer_ack_blackhole -4.94KiB -0.02 18.38% 23.77MiB 727.19KiB 14.8KiB 0 0.0298664 23.77MiB 749.02KiB 15.24KiB 0 0.0307692 False False
http_pipelines_blackhole_acks -5.78KiB -0.12 28.57% 4.55MiB 546.98KiB 11.2KiB 0 0.117372 4.54MiB 544.37KiB 11.12KiB 0 0.116958 False False
file_to_blackhole -169.57KiB -0.17 95.74% 95.34MiB 2.62MiB 54.48KiB 0 0.02746 95.17MiB 3.07MiB 63.42KiB 0 0.0322564 False False
syslog_regex_logs2metric_ddmetrics -29.15KiB -0.22 85.12% 12.8MiB 680.38KiB 13.85KiB 0 0.0519109 12.77MiB 721.36KiB 14.68KiB 0 0.05516 False False
http_to_http_acks -89.94KiB -0.49 30.08% 17.99MiB 7.86MiB 164.45KiB 0 0.437177 17.9MiB 7.88MiB 164.67KiB 0 0.440079 True True
http_pipelines_blackhole -23.66KiB -0.51 82.24% 4.51MiB 600.97KiB 12.31KiB 0 0.130096 4.49MiB 613.11KiB 12.5KiB 0 0.133408 False False
datadog_agent_remap_blackhole -405.39KiB -0.58 100.00% 68.62MiB 1.36MiB 28.46KiB 0 0.0197934 68.22MiB 1.37MiB 28.7KiB 0 0.0200723 False False
datadog_agent_remap_datadog_logs_acks -714.37KiB -0.97 100.00% 72.22MiB 3.13MiB 65.38KiB 0 0.0433191 71.52MiB 3.23MiB 67.68KiB 0 0.0452041 False False
http_pipelines_no_grok_blackhole -190.21KiB -1 100.00% 18.53MiB 1.32MiB 27.64KiB 0 0.0713082 18.34MiB 1.45MiB 30.18KiB 0 0.0787975 False False
datadog_agent_remap_datadog_logs -792.01KiB -1.1 100.00% 70.26MiB 3.81MiB 79.44KiB 0 0.0541504 69.49MiB 4.35MiB 90.86KiB 0 0.0625452 False False
splunk_transforms_splunk3 -153.82KiB -1.17 98.28% 12.8MiB 2.18MiB 45.54KiB 0 0.170298 12.65MiB 2.18MiB 45.71KiB 0 0.172667 False False
syslog_log2metric_humio_metrics -192.6KiB -1.31 100.00% 14.31MiB 581.88KiB 11.86KiB 0 0.039701 14.12MiB 436.53KiB 8.93KiB 0 0.0301809 False False
syslog_humio_logs -272.18KiB -1.49 100.00% 17.85MiB 400.52KiB 8.21KiB 0 0.021904 17.59MiB 384.17KiB 7.86KiB 0 0.0213273 False False
syslog_log2metric_splunk_hec_metrics -312.85KiB -1.62 100.00% 18.89MiB 855.26KiB 17.4KiB 0 0.0442162 18.58MiB 623.63KiB 12.71KiB 0 0.0327716 False False
syslog_splunk_hec_logs -327.45KiB -1.77 100.00% 18.11MiB 329.0KiB 6.72KiB 0 0.017735 17.79MiB 288.01KiB 5.89KiB 0 0.015804 False False

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Soak Test Results

Baseline: 1ba91c9
Comparison: 7c05455
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_loki 504.78KiB 3.43 100.00% 14.36MiB 693.28KiB 14.13KiB 0 0.0471513 14.85MiB 550.06KiB 11.24KiB 0 0.0361686 False False
syslog_humio_logs 374.98KiB 2.21 100.00% 16.56MiB 1.44MiB 30.32KiB 0 0.0872162 16.92MiB 1.25MiB 26.27KiB 0 0.0740173 False False
splunk_hec_route_s3 249.58KiB 1.24 99.99% 19.67MiB 2.11MiB 44.17KiB 0 0.107418 19.91MiB 2.1MiB 43.81KiB 0 0.105231 False False
datadog_agent_remap_datadog_logs_acks 722.89KiB 1.02 100.00% 69.31MiB 4.87MiB 101.84KiB 0 0.0703015 70.01MiB 5.49MiB 114.61KiB 0 0.0783307 False False
http_pipelines_blackhole_acks 41.99KiB 0.91 98.67% 4.51MiB 596.02KiB 12.19KiB 0 0.128954 4.55MiB 577.12KiB 11.79KiB 0 0.123741 False False
socket_to_socket_blackhole 122.86KiB 0.9 100.00% 13.33MiB 513.24KiB 10.45KiB 0 0.037586 13.45MiB 468.74KiB 9.56KiB 0 0.0340214 False False
http_pipelines_no_grok_blackhole 62.24KiB 0.32 88.82% 18.92MiB 1.34MiB 27.97KiB 0 0.0705807 18.98MiB 1.31MiB 27.37KiB 0 0.0690716 False False
http_to_http_noack 69.19KiB 0.28 99.96% 23.78MiB 919.59KiB 18.75KiB 0 0.0377603 23.85MiB 243.48KiB 4.97KiB 0 0.00996927 False False
fluent_elasticsearch 26.04KiB 0.03 94.55% 79.45MiB 669.45KiB 13.49KiB 0 0.00822711 79.47MiB 54.3KiB 1.09KiB 0 0.000667153 False False
splunk_hec_indexer_ack_blackhole -445.71B -0 1.52% 23.76MiB 791.34KiB 16.1KiB 0 0.0325214 23.76MiB 793.45KiB 16.14KiB 0 0.0326086 False False
splunk_hec_to_splunk_hec_logs_noack -261.83B -0 2.13% 23.84MiB 331.47KiB 6.79KiB 0 0.0135772 23.84MiB 331.19KiB 6.78KiB 0 0.0135656 False False
http_to_http_json 466.96B 0 3.67% 23.84MiB 343.57KiB 7.02KiB 0 0.0140694 23.84MiB 343.17KiB 7.0KiB 0 0.0140525 False False
splunk_hec_to_splunk_hec_logs_acks -5.35KiB -0.02 18.79% 23.77MiB 772.42KiB 15.71KiB 0 0.031734 23.76MiB 790.82KiB 16.09KiB 0 0.032497 False False
splunk_transforms_splunk3 -17.7KiB -0.13 21.29% 12.87MiB 2.23MiB 46.58KiB 0 0.173302 12.86MiB 2.2MiB 46.11KiB 0 0.171369 False False
datadog_agent_remap_blackhole_acks -116.5KiB -0.16 80.52% 72.27MiB 3.53MiB 73.64KiB 0 0.048824 72.16MiB 2.46MiB 51.47KiB 0 0.0341459 False False
file_to_blackhole -200.83KiB -0.21 96.92% 95.33MiB 3.0MiB 62.36KiB 0 0.0314541 95.13MiB 3.34MiB 68.96KiB 0 0.0351047 False False
http_pipelines_blackhole -28.34KiB -0.59 90.43% 4.66MiB 594.43KiB 12.18KiB 0 0.124431 4.64MiB 581.85KiB 11.87KiB 0 0.122526 False False
syslog_regex_logs2metric_ddmetrics -95.64KiB -0.73 100.00% 12.83MiB 733.63KiB 14.94KiB 0 0.0558401 12.73MiB 823.42KiB 16.75KiB 0 0.0631338 False False
datadog_agent_remap_blackhole -749.88KiB -1.02 100.00% 72.01MiB 1.37MiB 28.67KiB 0 0.0190121 71.28MiB 822.04KiB 16.81KiB 0 0.0112606 False False
syslog_log2metric_humio_metrics -222.82KiB -1.5 100.00% 14.47MiB 695.53KiB 14.19KiB 0 0.0469308 14.25MiB 657.22KiB 13.45KiB 0 0.0450229 False False
syslog_log2metric_splunk_hec_metrics -312.51KiB -1.79 100.00% 17.05MiB 1.38MiB 28.79KiB 0 0.0810932 16.74MiB 1.34MiB 27.93KiB 0 0.0799628 False False
syslog_splunk_hec_logs -333.86KiB -1.8 100.00% 18.12MiB 320.43KiB 6.54KiB 0 0.0172656 17.79MiB 279.24KiB 5.71KiB 0 0.0153218 False False
datadog_agent_remap_datadog_logs -1.77MiB -2.44 100.00% 72.62MiB 3.12MiB 65.14KiB 0 0.0429305 70.84MiB 4.08MiB 85.4KiB 0 0.0575889 False False
http_to_http_acks -716.33KiB -3.93 99.77% 17.81MiB 7.83MiB 163.65KiB 0 0.43936 17.11MiB 8.04MiB 168.02KiB 0 0.469617 True True

jszwedko pushed a commit that referenced this pull request Jun 8, 2022
* fix(kubernetes_logs): Compile kube-rs with openssl

This is to avoid breaking kubernetes_source inside clusters with k3s.
For more info check the issue kube-rs/kube#805

* +e2e ci

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@jaysonsantos jaysonsantos deleted the use-kube-rs-with-openssl branch June 9, 2022 06:01
jszwedko pushed a commit that referenced this pull request Jun 9, 2022
* fix(kubernetes_logs): Compile kube-rs with openssl

This is to avoid breaking kubernetes_source inside clusters with k3s.
For more info check the issue kube-rs/kube#805

* +e2e ci

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
jszwedko pushed a commit that referenced this pull request Jun 9, 2022
* fix(kubernetes_logs): Compile kube-rs with openssl

This is to avoid breaking kubernetes_source inside clusters with k3s.
For more info check the issue kube-rs/kube#805

* +e2e ci

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

Co-authored-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: k8s e2e all targets Run Kubernetes E2E test suite for all targets (instead of just the essential subset) ci-condition: k8s e2e tests enable Run Kubernetes E2E test suite for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector 0.22.0 breaks with kubernetes_source
4 participants