chore: Remove explicit lazy_static in project #11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of lazy_static! in favor of OnceCell's Lazy. They are functionally similar although OnceCell's implementation has better characteristics in contended situations. This change was motivated by examination of the profiling results from #11206 where a regex to do with date parsing was seen before a CPU quiet period. It's unknown if this change will materially impact that, however we should no longer use lazy_static and so the time seemed ripe. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: d86a2f0 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6201f642ef565100089a5f30 |
github-actions
bot
added
domain: core
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Soak Test ResultsBaseline: 1bd5526 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes with confidence ≥ 90.00%: Fine details of change detection per experiment.
Fine details of each soak run.
|
JeanMertz
approved these changes
Feb 8, 2022
Comment on lines
-8
to
+15
| use glob::glob; | ||
| use indexmap::IndexMap; | ||
| use lazy_static::lazy_static; | ||
|
|
||
| use super::{ | ||
| builder::ConfigBuilder, format, validation, vars, ComponentKey, Config, ConfigPath, Format, | ||
| FormatHint, TransformOuter, | ||
| }; | ||
| use crate::signal; | ||
| use glob::glob; | ||
| use indexmap::IndexMap; | ||
| use once_cell::sync::Lazy; |
There was a problem hiding this comment.
Seems like some unintended changes got pulled in. I've seen this in other PRs as well, I wonder if it's because of a manually ran rustfmt configuration (via #10496) doesn't match people's editor configs.
There was a problem hiding this comment.
Yeah that seems likely. Might be worth having people take a look at their local configs and try to align them with what we did there.
lukesteensen
approved these changes
Feb 8, 2022
Comment on lines
-8
to
+15
| use glob::glob; | ||
| use indexmap::IndexMap; | ||
| use lazy_static::lazy_static; | ||
|
|
||
| use super::{ | ||
| builder::ConfigBuilder, format, validation, vars, ComponentKey, Config, ConfigPath, Format, | ||
| FormatHint, TransformOuter, | ||
| }; | ||
| use crate::signal; | ||
| use glob::glob; | ||
| use indexmap::IndexMap; | ||
| use once_cell::sync::Lazy; |
There was a problem hiding this comment.
Yeah that seems likely. Might be worth having people take a look at their local configs and try to align them with what we did there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the use of lazy_static! in favor of OnceCell's Lazy. They
are functionally similar although OnceCell's implementation has better
characteristics in contended situations. This change was motivated by
examination of the profiling results from #11206 where a regex to do with date
parsing was seen before a CPU quiet period. It's unknown if this change will
materially impact that, however we should no longer use lazy_static and so the
time seemed ripe.
Signed-off-by: Brian L. Troutwine brian@troutwine.us