Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove the Sink impl from Fanout #11206

Closed
wants to merge 3 commits into from
Closed

chore: Remove the Sink impl from Fanout #11206

wants to merge 3 commits into from

Commits on Feb 9, 2022

  1. Remove the Sink impl from Fanout 

    This commit is kind of a peer to #11197, in pursuit of #10144. The basic idea
here is we want to get rid of the lock-step behavior that a strict Sink requires
for fanning out, because we know that we have issues with slow receivers. This
commit is not nearly so intrusive as #11197 but does allow for incremental
progress among the cohort of downstream sinks.

I still have some tests commented out. The error propagation story here is yet
to be worked on.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Co-authored-by: Luke Steensen <luke.steensen@gmail.com>
    @blt @lukesteensen
    blt and lukesteensen committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    9397baa View commit details
    Browse the repository at this point in the history

  2. address nits 

    Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
    @blt
    blt committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4b1e68a View commit details
    Browse the repository at this point in the history

  3. Update lib/vector-core/src/fanout.rs 

    Co-authored-by: Bruce Guenter <bruce.guenter@datadoghq.com>
    @blt @bruceg
    blt and bruceg committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    497a94d View commit details
    Browse the repository at this point in the history