Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add values.go implementation #1770

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Aug 16, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 7, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c0582e
Status: ✅  Deploy successful!
Preview URL: https://dedbe9db.vald.pages.dev
Branch Preview URL: https://feature-charts-valuesgo.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 7, 2022

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Signed-off-by: kpango <kpango@vdaas.org>

<a name="vald-v1-Filter"></a>

### Filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Filter
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC


<a name="vald-v1-Insert"></a>

### Insert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Insert
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.03%. Comparing base (8ec79af) to head (7c0582e).
Report is 428 commits behind head on main.

Files Patch % Lines
pkg/agent/sidecar/usecase/sidecar/sidecar.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   30.27%   28.03%   -2.24%     
==========================================
  Files         373      348      -25     
  Lines       33713    32573    -1140     
==========================================
- Hits        10207     9133    -1074     
+ Misses      23113    23057      -56     
+ Partials      393      383      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ExternalTrafficPolicy string `json:"externalTrafficPolicy,omitempty"`
Hpa *Hpa `json:"hpa,omitempty"`
Image *Image `json:"image,omitempty"`
ExternalTrafficPolicy corev1.ServiceExternalTrafficPolicyType `json:"externalTrafficPolicy,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
json(snake): got 'externalTrafficPolicy' want 'external_traffic_policy' (tagliatelle)

@@ -71,7 +71,7 @@
PersistentVolume *PersistentVolume `json:"persistentVolume,omitempty"`

// pod annotations
PodAnnotations *PodAnnotations `json:"podAnnotations,omitempty"`
PodAnnotations *Annotations `json:"podAnnotations,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
json(snake): got 'podAnnotations' want 'pod_annotations' (tagliatelle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants