Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the RSpec cassette name shorthand #821

Merged
merged 1 commit into from
May 29, 2020
Merged

Document the RSpec cassette name shorthand #821

merged 1 commit into from
May 29, 2020

Conversation

nicolasiensen
Copy link
Contributor

In this pull request, we are documenting how to use the RSpec shorthand feature to override the name of a cassette file.

Relates to #774 and fixes #785.

@nicolasiensen
Document the RSpec cassette name shorthand
5c6796e 
In this commit, we are documenting how to use the RSpec shorthand
feature to override the name of a cassette file.

Relates to #774 and #785.
olleolleolle
olleolleolle approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

The writing is clear and concise.

@olleolleolle olleolleolle merged commit a87b947 into vcr:master May 29, 2020
@nicolasiensen nicolasiensen deleted the document-rspec-name-shorthand branch May 29, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@krainboltgreene krainboltgreene krainboltgreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the cassette name shorthand feature, aka "RSpec metadata value as cassette name if value is String"
3 participants
@nicolasiensen @olleolleolle @krainboltgreene