New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VCR.use_cassettes method implementation and spec #730

Merged

krainboltgreene merged 1 commit into vcr:master from skryukov:fix_use_cassettes_method

Mar 4, 2019

Contributor

skryukov commented Dec 18, 2018

update VCR.use_cassettes spec to test method arguments
fix VCR.use_cassettes raises no implicit conversion of nil into Hash


          Fix VCR.use_cassettes method implementation and spec

ea3b8d5

serggl mentioned this pull request

Fix flaws in VCR.use_cassettes helper #731

Closed

serggl commented Jan 14, 2019

@krainboltgreene can you please review this?

while trying to use use_cassettes I also found 2 flaws:

options parameter is required, though it is not documented. if you try to use it without options provided it will crash:

VCR.use_cassettes([{ name: 'cassette a' }, { name: 'cassette b' }]) do {} =>

TypeError:
       no implicit conversion of nil into Hash

options parameter was ignored for the first cassette definition provided

I think this PR should fix both of these

krainboltgreene approved these changes

View reviewed changes

krainboltgreene merged commit 0b7fc91 into vcr:master

skryukov deleted the fix_use_cassettes_method branch

March 4, 2019 18:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment