Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RSpec metadata value as cassette name if value is String #774

Merged
merged 2 commits into from Dec 17, 2019
Merged

Use RSpec metadata value as cassette name if value is String #774

merged 2 commits into from Dec 17, 2019

Conversation

evansagge
Copy link
Contributor 

describe Foo, vcr: { cassette_name: 'bar' } do

could be less verbose. If the metadata value for vcr is a String, we should be able to safely use that string as the cassette name:

describe Foo, vcr: 'bar' do

olleolleolle
olleolleolle approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an enjoyable shorthand!

@olleolleolle olleolleolle merged commit 5a85510 into vcr:master Dec 17, 2019
@olleolleolle olleolleolle mentioned this pull request Dec 20, 2019
Closed
@nicolasiensen nicolasiensen mentioned this pull request May 28, 2020
Merged
olleolleolle pushed a commit that referenced this pull request May 29, 2020
@nicolasiensen
Document the RSpec cassette name shorthand (#821)
a87b947 
In this commit, we are documenting how to use the RSpec shorthand
feature to override the name of a cassette file.

Relates to #774 and #785.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@krainboltgreene krainboltgreene krainboltgreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evansagge @olleolleolle @krainboltgreene