-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove label and placeholder from context and form, add optional provideDefaultLabelFromFieldName property to bridges. #1248
Conversation
I run into a problem implementing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand, as soon as we migrate to Zod in tests or Simple Schema solves the issue with the label
s, we could remove all of these label: ''
from tests?
Conflicts: packages/uniforms-semantic/__tests__/LongTextField.tsx packages/uniforms-semantic/__tests__/NumField.tsx
Correct. Since we get rid of |
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
- Coverage 97.48% 96.51% -0.97%
==========================================
Files 231 231
Lines 3821 3821
Branches 1031 1029 -2
==========================================
- Hits 3725 3688 -37
- Misses 4 12 +8
- Partials 92 121 +29
|
Changes are described here: #973 (comment).
This version doesn't include the
provideDefaultLabelFromFieldName
bridge property in SimpleSchema, since it always delivers a 'label' property. We cannot distinguish whether it was inferred from the field name or entered manually into the schema.