Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #1

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Tests #1

merged 3 commits into from
Jan 8, 2020

Conversation

janowsiany
Copy link

@janowsiany janowsiany commented Mar 24, 2017 •
edited

Configure tests environment and add simple tests for no-console rule.

@janowsiany janowsiany self-assigned this Mar 24, 2017
@janowsiany
Copy link
Author

janowsiany commented Mar 26, 2017 •
edited

Should switch to mocha as jest doesn't do well with expected and actual?
jestjs/jest#3173

Perhaps i can use ava

@MacRusher
Copy link
Member

If ESLint tests can be run concurrently (and I believe they can) then AVA may be a really good choice.

Using Jest as a runner if we're not using anything special from it and it it has this know bug may not be a good idea. You can always just run node testFile.js :)

@kentcdodds
Copy link

FYI, I'm currently working on making Jest behave better with this (as referenced jestjs/jest#3173). Hopefully in the next version of Jest will have the better messaging.

If ESLint tests can be run concurrently (and I believe they can) then AVA may be a really good choice.

Note that Jest also runs tests concurrently :)

@janowsiany
Copy link
Author

janowsiany commented Mar 28, 2017 •
edited

Thanks for your attention! If you will need any help with this PR, feel free to ping me!

@radekmie radekmie added this to Needs triage in Open Source (migrated) Sep 25, 2019
radekmie
radekmie approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time, huh?

Open Source (migrated) automation moved this from Needs triage to Review Jan 8, 2020
@radekmie radekmie merged commit d0f2839 into master Jan 8, 2020
Open Source (migrated) automation moved this from Review to Closed Jan 8, 2020
@radekmie radekmie deleted the tests branch January 8, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacRusher MacRusher MacRusher approved these changes

@radekmie radekmie radekmie approved these changes

@MichalW MichalW MichalW approved these changes

Assignees

@janowsiany janowsiany

Labels
enhancement
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janowsiany @MacRusher @kentcdodds @radekmie @MichalW