fix snapshot publishing #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
commented
Mar 23, 2023
plugin/src/main/kotlin/com/vanniktech/maven/publish/ProjectExtensions.kt
Outdated
Show resolved
Hide resolved
vanniktech
approved these changes
Mar 24, 2023
kyeotic
added a commit
to cashapp/tempest
that referenced
this pull request
Jun 5, 2023
Gets a fix for SNAPSHOT builds [0.25.1](vanniktech/gradle-maven-publish-plugin#545)
kyeotic
added a commit
to cashapp/tempest
that referenced
this pull request
Jun 5, 2023
Gets a fix for SNAPSHOT builds [0.25.1](vanniktech/gradle-maven-publish-plugin#545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stagingRepositoryId.isPresentcheck inpublishingUrlwill cause theProviderto be evaluated which then will makerequireNotNullthrow becausestagingRepositoryIdis expected to benullin this case. I moved the check intopublishingUrlto resolve this.Tested the solution manually by publishing to maven local and trying out both snapshot and release publishing in another project using that version. I need to find a way to have this as an automated test somehow.
Closes #544