add specific support to Gradle plugin publish plugin #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Mar 23, 2023
| /** | ||
| * To be used for `com.gradle.plugin-publish` projects. Uses the default publication that gets created by that plugin. | ||
| */ | ||
| class GradlePublishPlugin : Platform() { |
There was a problem hiding this comment.
Suggested change
| class GradlePublishPlugin : Platform() { | |
| object GradlePublishPlugin : Platform() { |
?
There was a problem hiding this comment.
Object is awkward to use from Groovy unfortunately
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.gradle.plugin-publishwill already create a sources jar and javadoc jar automatically and attach it to the publication which then conflicts with the ones added by us. To resolve this I'm adding an extraPlatformfor that plugin which which will not add anything. In the main plugincom.gradle.plugin-publishis ranked higher thanjava-gradle-pluginso that it will be prioritized and avoid this issue.With this we'll be incompatible with 0.21.0 of
com.gradle.plugin-publishbecause that didn't create sources and javadoc jars.Closes #542
Closes #536