Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented what was described by me in #1766. #1767

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Implemented what was described by me in #1766. #1767

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24b069
Implemented what was described by me in issue#1766.
Apr 23, 2024
64c7057
fixed linting isssues in fs.go with gofmt -e -d -s
Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions fs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,12 @@
if err == nil {
return ff, nil
}
if mustCompress && err == errNoCreatePermission {

Check failure on line 1236 in fs.go

View workflow job for this annotation

GitHub Actions / lint 

File is not `gofmt`-ed with `-s` (gofmt)
ctx.Logger().Printf("insufficient permissions for saving compressed file for %q. Serving uncompressed file. "+
"Allow write access to the directory with this file in order to improve fasthttp performance", indexFilePath)
mustCompress = false
return h.openFSFile(indexFilePath, mustCompress, fileEncoding)
}
if !errors.Is(err, fs.ErrNotExist) {
return nil, fmt.Errorf("cannot open file %q: %w", indexFilePath, err)
}
Expand Down