-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: support HostClient.MaxGreedyConns #1655
Open
bingoohuang
wants to merge
8
commits into
valyala:master
Choose a base branch
from
bingoohuang:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0830ea2
Feature: support MaxGreedyConns for HostClient to create new connecti…
bingoohuang ab32459
TestClientMaxGreedyConnsPerHost
bingoohuang ef406fe
Merge pull request #2 from valyala/master
bingoohuang f5bcb6f
TCPDialer.LocalAddrFunc
bingoohuang d1742a6
if UsingProxy, req.Header.SetRequestURIBytes(uri.FullURI())
bingoohuang eed376a
Merge pull request #3 from valyala/master
bingoohuang 569d914
ConnAcquiredCallback
bingoohuang 21147e9
Merge pull request #4 from valyala/master
bingoohuang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,12 @@ type Request struct { | |
// By default redirect path values are normalized, i.e. | ||
// extra slashes are removed, special characters are encoded. | ||
DisableRedirectPathNormalizing bool | ||
|
||
// UsingProxy 是否使用代理 | ||
UsingProxy bool | ||
|
||
// ConnAcquiredCallback 连接获取后回调,用于获取连接信息(例如 *tls.Conn 中的证书信息等) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
ConnAcquiredCallback func(conn net.Conn) | ||
} | ||
|
||
// Response represents HTTP response. | ||
|
@@ -1582,7 +1588,12 @@ func (req *Request) Write(w *bufio.Writer) error { | |
} else if !req.UseHostHeader { | ||
req.Header.SetHostBytes(host) | ||
} | ||
req.Header.SetRequestURIBytes(uri.RequestURI()) | ||
|
||
if req.UsingProxy { | ||
req.Header.SetRequestURIBytes(uri.FullURI()) | ||
} else { | ||
req.Header.SetRequestURIBytes(uri.RequestURI()) | ||
} | ||
|
||
if len(uri.username) > 0 { | ||
// RequestHeader.SetBytesKV only uses RequestHeader.bufKV.key | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the non-english comments?