Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client.go Simplify default UA logic #1466

Merged
merged 1 commit into from Jan 2, 2023
Merged

client.go Simplify default UA logic #1466

merged 1 commit into from Jan 2, 2023

Commits on Jan 1, 2023

  1. client.go Simplify default UA logic 

    The getClientName() checks if !NoDefaultUserAgentHeader then returns the Client.Name field.
But it also saves it to atomic field clientName. This is not needed and logic can be simplified.
Previously the clientName vas a byte slice that was copied from c.Name and cached. See 02e0722

Fix valyala#1458
    @stokito
    stokito committed Jan 1, 2023
    Copy the full SHA
    9d568fa View commit details
    Browse the repository at this point in the history