Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for the response of pipelineWork in background and return it to pool #1435

Closed
wants to merge 1 commit into from
Closed

Wait for the response of pipelineWork in background and return it to pool #1435

wants to merge 1 commit into from

Conversation

panjf2000
Copy link
Contributor

@panjf2000 panjf2000 commented Nov 16, 2022 •
edited

Updates #1433

@panjf2000
Copy link
Contributor Author

@erikdubbelboer PTAL

erikdubbelboer
erikdubbelboer requested changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is worth the effort. The goroutine probably has a bigger overhead than just letting the allocation go to waste and having to allocate a new w next time don't you think?

@panjf2000
Copy link
Contributor Author

I don't think this is worth the effort. The goroutine probably has a bigger overhead than just letting the allocation go to waste and having to allocate a new w next time don't you think?

Well, the memory waste caused by the case of timeout is indeed rare, I guess we can live with that, also thanks for your reply.

@panjf2000 panjf2000 closed this Nov 16, 2022
@panjf2000 panjf2000 deleted the fix-pool-leak branch November 16, 2022 08:13
@Tristin-C
Copy link

Big man, is that going to lead to a leak? Causing the number of coroutines to soar? Because I seem to have that problem

This was referenced May 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panjf2000 @Tristin-C @erikdubbelboer