New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.19 Support #1355
Merged
Merged
Add Go 1.19 Support #1355
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
afb45d1
Update Go Version to Go1.19.x And add cache
Aoang 655640c
Fix CI Line endings
Aoang 4886250
Update test CI Go Version to Go1.19.x And add cache
Aoang 90b50f2
Update Gosec Security Scanner CI to securego/gosec@v2.12.0
Aoang a55b952
Format comment
Aoang 09146cd
Fix doc structure
Aoang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,35 +3,53 @@ Package fasthttp provides fast HTTP server and client API. | |
|
||
Fasthttp provides the following features: | ||
|
||
* Optimized for speed. Easily handles more than 100K qps and more than 1M | ||
concurrent keep-alive connections on modern hardware. | ||
* Optimized for low memory usage. | ||
* Easy 'Connection: Upgrade' support via RequestCtx.Hijack. | ||
* Server provides the following anti-DoS limits: | ||
|
||
* The number of concurrent connections. | ||
* The number of concurrent connections per client IP. | ||
* The number of requests per connection. | ||
* Request read timeout. | ||
* Response write timeout. | ||
* Maximum request header size. | ||
* Maximum request body size. | ||
* Maximum request execution time. | ||
* Maximum keep-alive connection lifetime. | ||
* Early filtering out non-GET requests. | ||
|
||
* A lot of additional useful info is exposed to request handler: | ||
|
||
* Server and client address. | ||
* Per-request logger. | ||
* Unique request id. | ||
* Request start time. | ||
* Connection start time. | ||
* Request sequence number for the current connection. | ||
|
||
* Client supports automatic retry on idempotent requests' failure. | ||
* Fasthttp API is designed with the ability to extend existing client | ||
and server implementations or to write custom client and server | ||
implementations from scratch. | ||
- Optimized for speed. Easily handles more than 100K qps and more than 1M | ||
concurrent keep-alive connections on modern hardware. | ||
|
||
- Optimized for low memory usage. | ||
|
||
- Easy 'Connection: Upgrade' support via RequestCtx.Hijack. | ||
|
||
- Server provides the following anti-DoS limits: | ||
|
||
- The number of concurrent connections. | ||
|
||
- The number of concurrent connections per client IP. | ||
|
||
- The number of requests per connection. | ||
|
||
- Request read timeout. | ||
|
||
- Response write timeout. | ||
|
||
- Maximum request header size. | ||
|
||
- Maximum request body size. | ||
|
||
- Maximum request execution time. | ||
|
||
- Maximum keep-alive connection lifetime. | ||
|
||
- Early filtering out non-GET requests. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These need to be sub bullet points like the original. |
||
|
||
- A lot of additional useful info is exposed to request handler: | ||
|
||
- Server and client address. | ||
|
||
- Per-request logger. | ||
|
||
- Unique request id. | ||
|
||
- Request start time. | ||
|
||
- Connection start time. | ||
|
||
- Request sequence number for the current connection. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These need to be sub bullet points like the original. |
||
|
||
- Client supports automatic retry on idempotent requests' failure. | ||
|
||
- Fasthttp API is designed with the ability to extend existing client | ||
and server implementations or to write custom client and server | ||
implementations from scratch. | ||
*/ | ||
package fasthttp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aoang curious why you ended up doing this? In wazero, we're noticing the cache doesn't seem to work for golangci-lint and wondering if there's some difference between this and hard-coding (considering it is only run with ubuntu). Any thoughts appreciated!
https://github.com/tetratelabs/wazero/blob/main/.github/workflows/commit.yaml#L46-L52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continue tetratelabs/wazero#804