Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Keep the memory usage of the service at a stable level #1216

Merged
merged 8 commits into from Mar 3, 2022
Merged

feature: Keep the memory usage of the service at a stable level #1216

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b0790c
feature: add request and response body size limit, it prevents the la…
Rennbon Feb 15, 2022
a802e7e
fix: http.go fmt
Rennbon Feb 15, 2022
2ec424d
refact: optimize code naming
Rennbon Feb 25, 2022
d9c8598
Update http.go
Rennbon Mar 1, 2022
d8ef622
Update http.go
Rennbon Mar 1, 2022
31e16a4
Update http.go
Rennbon Mar 1, 2022
fc15912
Update http.go
Rennbon Mar 1, 2022
d87b7fd
Update http.go
Rennbon Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions http.go
View file
Open in desktop
Expand Up @@ -17,6 +17,18 @@ import (
"github.com/valyala/bytebufferpool"
)

var (
requestBodyPoolSizeLimit = -1
responseBodyPoolSizeLimit = -1
)

// SetBodySizePoolLimit set the max body size for bodies to be returned to the pool.
// If the body size is larger it will be released instead of put back into the pool for reuse.
func SetBodySizePoolLimit(reqBodyLimit, respBodyLimit int) {
requestBodyPoolSizeLimit = reqBodyLimit
responseBodyPoolSizeLimit = respBodyLimit
}

// Request represents HTTP request.
//
// It is forbidden copying Request instances. Create new instances
Expand Down Expand Up @@ -957,6 +969,9 @@ func readMultipartForm(r io.Reader, boundary string, size, maxInMemoryFileSize i

// Reset clears request contents.
func (req *Request) Reset() {
if requestBodyPoolSizeLimit >= 0 && req.body != nil {
req.ReleaseBody(requestBodyPoolSizeLimit)
}
req.Header.Reset()
req.resetSkipHeader()
req.timeout = 0
Expand Down Expand Up @@ -986,6 +1001,9 @@ func (req *Request) RemoveMultipartFormFiles() {

// Reset clears response contents.
func (resp *Response) Reset() {
if responseBodyPoolSizeLimit >= 0 && resp.body != nil {
resp.ReleaseBody(responseBodyPoolSizeLimit)
}
resp.Header.Reset()
resp.resetSkipHeader()
resp.SkipBody = false
Expand Down