fix: reset request after reset user values on keep-alive connections

[savsgio]

This fix the use cases that reference a RequestCtx into user values that implements io.Closer

Example:

func handler(ctx *fasthttp.RequestCtx) {
	rd := acquireRequestDuration()
	rd.ctx = ctx
	rd.start = time.Now()

	ctx.SetUserValue("__http::requestDuration__", rd)
}

func (rd *requestDuration) Close() error {
	duration := time.Since(rd.start)
	statusCode := strconv.Itoa(rd.ctx.Response.StatusCode())  // ISSUE: INVALID VALUE, ALWAYS IS 200
	method := string(rd.ctx.Request.Header.Method())  // ISSUE: INVALID VALUE
	path := string(rd.ctx.Request.URI().Path())  // ISSUE: INVALID VALUE

	requestsDurationHistogramVec.WithLabelValues(
		statusCode, method, path,
	).Observe(duration.Seconds())

	releaseRequestDuration(rd)

	return nil
}

[savsgio]

The test in go 1.15 fails because timeout. Could you run it again, please!

[erikdubbelboer]

I'm not sure I understand what this is for. Can you maybe add a test case that fails before your change and passes afterwards?

[erikdubbelboer]

Thanks, good fix!