Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Upgrade fasthttp module #129

Closed
cthulhu-rider opened this issue Mar 4, 2022 · 2 comments · Fixed by #131
Closed

Upgrade fasthttp module #129

cthulhu-rider opened this issue Mar 4, 2022 · 2 comments · Fixed by #131
Assignees
Labels
enhancement Improving existing functionality

Comments

@cthulhu-rider
Copy link
Contributor

For now the latest version of fasthttp is v1.33.0. I think I'd be useful to upgrade the used module.

I briefly ran through the changes that may affect the application:

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality triage labels Mar 4, 2022
@KirillovDenis
Copy link
Contributor

At least we should upgrade to v1.34.0 because there was a fix without which tests sometimes fail. Beside this using v1.34.0 encountered with strange bug:

panic: context: internal error: missing cancel error

goroutine 22075 [running]:
context.(*cancelCtx).cancel(0xc000be4820, 0x90, {0x0, 0x0})
        /usr/local/go/src/context/context.go:399 +0x27e
context.propagateCancel.func1()
        /usr/local/go/src/context/context.go:281 +0xe2
created by context.propagateCancel
        /usr/local/go/src/context/context.go:278 +0x1d0

I'm not sure if the reason v1.34.0 or problem in neofs-http-gw code

@alexvanin
Copy link
Contributor

Don't think it is related, but I had some context cancel propagation errors in integration test with -race flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants