Release UseHostHeader in ReleaseRequest() (#1185)

* Fix UseHostHeader for DoTimeout + tests * Release UseHostHeader in ReleaseRequest() + tests
valyala · Dec 28, 2021 · c727b99 · c727b99
1 parent 6c0518b
commit c727b99
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/http.go b/http.go
@@ -960,6 +960,7 @@ func (req *Request) Reset() {
 	req.Header.Reset()
 	req.resetSkipHeader()
 	req.timeout = 0
+	req.UseHostHeader = false
 }
 
 func (req *Request) resetSkipHeader() {

diff --git a/http_test.go b/http_test.go
@@ -757,6 +757,7 @@ func TestUseHostHeader(t *testing.T) {
 }
 
 func TestUseHostHeader2(t *testing.T) {
+	t.Parallel()
 	testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if r.Host != "SomeHost" {
 			http.Error(w, fmt.Sprintf("Expected Host header to be '%s', but got '%s'", "SomeHost", r.Host), http.StatusBadRequest)
@@ -791,6 +792,19 @@ func TestUseHostHeader2(t *testing.T) {
 	}
 }
 
+func TestUseHostHeaderAfterRelease(t *testing.T) {
+	t.Parallel()
+	req := AcquireRequest()
+	req.UseHostHeader = true
+	ReleaseRequest(req)
+
+	req = AcquireRequest()
+	defer ReleaseRequest(req)
+	if req.UseHostHeader {
+		t.Fatalf("UseHostHeader was not released in ReleaseRequest()")
+	}
+}
+
 func TestRequestBodyStreamMultipleBodyCalls(t *testing.T) {
 	t.Parallel()