client.go Make addMissingPort() public

It's needed for those who creates the instance of the HostClient manually.
valyala · Nov 25, 2022 · 606562f · 606562f
1 parent 51384ce
commit 606562f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/client.go b/client.go
@@ -494,7 +494,7 @@ func (c *Client) Do(req *Request, resp *Response) error {
 	hc := m[string(host)]
 	if hc == nil {
 		hc = &HostClient{
-			Addr:                          addMissingPort(string(host), isTLS),
+			Addr:                          AddMissingPort(string(host), isTLS),
 			Name:                          c.Name,
 			NoDefaultUserAgentHeader:      c.NoDefaultUserAgentHeader,
 			Dial:                          c.Dial,
@@ -1967,7 +1967,7 @@ func dialAddr(addr string, dial DialFunc, dialDualStack, isTLS bool, tlsConfig *
 		} else {
 			dial = Dial
 		}
-		addr = addMissingPort(addr, isTLS)
+		addr = AddMissingPort(addr, isTLS)
 	}
 	conn, err := dial(addr)
 	if err != nil {
@@ -2005,7 +2005,8 @@ func (c *HostClient) getClientName() []byte {
 	return clientName
 }
 
-func addMissingPort(addr string, isTLS bool) string {
+// AddMissingPort adds a port to a host if it is missing.
+func AddMissingPort(addr string, isTLS bool) string {
 	addrLen := len(addr)
 	if addrLen == 0 {
 		return addr

diff --git a/client_test.go b/client_test.go
@@ -2972,7 +2972,7 @@ func TestHttpsRequestWithoutParsedURL(t *testing.T) {
 	}
 }
 
-func Test_addMissingPort(t *testing.T) {
+func Test_AddMissingPort(t *testing.T) {
 	type args struct {
 		addr  string
 		isTLS bool
@@ -3029,8 +3029,8 @@ func Test_addMissingPort(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.want, func(t *testing.T) {
-			if got := addMissingPort(tt.args.addr, tt.args.isTLS); got != tt.want {
-				t.Errorf("addMissingPort() = %v, want %v", got, tt.want)
+			if got := AddMissingPort(tt.args.addr, tt.args.isTLS); got != tt.want {
+				t.Errorf("AddMissingPort() = %v, want %v", got, tt.want)
 			}
 		})
 	}