Skip to content

Commit

Permalink
Remove unused peekRawHeader
Browse files Browse the repository at this point in the history
  • Loading branch information
erikdubbelboer committed May 26, 2021
1 parent 7d13e18 commit 5bb5cfc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 60 deletions.
31 changes: 0 additions & 31 deletions header.go
Original file line number Diff line number Diff line change
Expand Up @@ -1804,37 +1804,6 @@ func (h *RequestHeader) parseFirstLine(buf []byte) (int, error) {
return len(buf) - len(bNext), nil
}

func peekRawHeader(buf, key []byte) []byte {
n := bytes.Index(buf, key)
if n < 0 {
return nil
}
if n > 0 && buf[n-1] != nChar {
return nil
}
n += len(key)
if n >= len(buf) {
return nil
}
if buf[n] != ':' {
return nil
}
n++
if buf[n] != ' ' {
return nil
}
n++
buf = buf[n:]
n = bytes.IndexByte(buf, nChar)
if n < 0 {
return nil
}
if n > 0 && buf[n-1] == rChar {
n--
}
return buf[:n]
}

func readRawHeaders(dst, buf []byte) ([]byte, int, error) {
n := bytes.IndexByte(buf, nChar)
if n < 0 {
Expand Down
29 changes: 0 additions & 29 deletions header_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1054,35 +1054,6 @@ func TestRequestHeaderProxyWithCookie(t *testing.T) {
}
}

func TestPeekRawHeader(t *testing.T) {
t.Parallel()

// empty header
testPeekRawHeader(t, "", "Foo-Bar", "")

// different case
testPeekRawHeader(t, "Content-Length: 3443\r\n", "content-length", "")

// no trailing crlf
testPeekRawHeader(t, "Content-Length: 234", "Content-Length", "")

// single header
testPeekRawHeader(t, "Content-Length: 12345\r\n", "Content-Length", "12345")

// multiple headers
testPeekRawHeader(t, "Host: foobar\r\nContent-Length: 434\r\nFoo: bar\r\n\r\n", "Content-Length", "434")

// lf without cr
testPeekRawHeader(t, "Foo: bar\nConnection: close\nAaa: bbb\ncc: ddd\n", "Connection", "close")
}

func testPeekRawHeader(t *testing.T, rawHeaders, key string, expectedValue string) {
v := peekRawHeader([]byte(rawHeaders), []byte(key))
if string(v) != expectedValue {
t.Fatalf("unexpected raw headers value %q. Expected %q. key %q, rawHeaders %q", v, expectedValue, key, rawHeaders)
}
}

func TestResponseHeaderFirstByteReadEOF(t *testing.T) {
t.Parallel()

Expand Down

0 comments on commit 5bb5cfc

Please sign in to comment.