New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change button color to black #5401
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5401 +/- ##
==========================================
- Coverage 86.24% 86.24% -0.01%
==========================================
Files 750 750
Lines 30556 30557 +1
Branches 5216 5216
==========================================
Hits 26354 26354
- Misses 3974 3975 +1
Partials 228 228
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -145,7 +145,6 @@ export default function PointsHome({ route, navigation }: Props) { | |||
onPress={onPressActivity} | |||
text={t('points.activity')} | |||
type={BtnTypes.GRAY_WITH_BORDER} | |||
fontStyle={typeScale.labelXSmall} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want to leave the font style as an option because of this. cc @kathaypacific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naw if it's just for points, i think we can remove it. i'm a fan of not having customisable styles, they can be convenient but they add extra complexity and facilitate inconsistency
src/app/MultichainBeta.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this file? I suppose it's outside of the scope of the ticket to delete.
Description
Test plan
Updated unit tests, manual tests:
send.mp4
buy.mp4
swap-disabled.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: