Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change button color to black #5401

Merged
merged 10 commits into from May 16, 2024
Merged

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented May 8, 2024

Description

  • Change primary button color to black
  • Set opacity at 25% when disabled
  • Set opacity of GRAY_WITH_BORDER to 50% when disabled

Test plan

Updated unit tests, manual tests:
token-details

send.mp4
buy.mp4
swap-disabled.mp4

Related issues

  • N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (db7459a) to head (ddbe908).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5401      +/-   ##
==========================================
- Coverage   86.24%   86.24%   -0.01%     
==========================================
  Files         750      750              
  Lines       30556    30557       +1     
  Branches     5216     5216              
==========================================
  Hits        26354    26354              
- Misses       3974     3975       +1     
  Partials      228      228              
Files Coverage Δ
src/app/MultichainBeta.tsx 90.90% <ø> (ø)
src/components/Button.tsx 100.00% <100.00%> (ø)
src/points/PointsHome.tsx 98.63% <ø> (ø)
src/send/EnterAmount.tsx 96.20% <ø> (ø)
src/tokens/TokenDetails.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7459a...ddbe908. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review May 8, 2024 22:43
@@ -145,7 +145,6 @@ export default function PointsHome({ route, navigation }: Props) {
onPress={onPressActivity}
text={t('points.activity')}
type={BtnTypes.GRAY_WITH_BORDER}
fontStyle={typeScale.labelXSmall}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may want to leave the font style as an option because of this. cc @kathaypacific

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naw if it's just for points, i think we can remove it. i'm a fan of not having customisable styles, they can be convenient but they add extra complexity and facilitate inconsistency

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this file? I suppose it's outside of the scope of the ticket to delete.

@finnian0826 finnian0826 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit a76f334 May 16, 2024
16 checks passed
@finnian0826 finnian0826 deleted the finnian0826/black-buttons branch May 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants