Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(renovate): turn off auto merge for major package version upgrades #5388

Merged
merged 5 commits into from May 22, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 3, 2024

Description

Prevents renovate from auto merging major upgrades to wallet dependencies.

Test plan

N/A

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (a36105f) to head (d383d69).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5388   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         756      757    +1     
  Lines       31233    31244   +11     
  Branches     5364     5364           
=======================================
+ Hits        26967    26978   +11     
  Misses       4033     4033           
  Partials      233      233           

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36105f...d383d69. Read the comment docs.

silasbw
silasbw previously requested changes May 4, 2024
Copy link
Collaborator

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for whipping this up. let's discuss with the team in the eng sync

@MuckT
Copy link
Collaborator Author

MuckT commented May 8, 2024

Results from the eng sync are that we will disable auto merge for major updates to the following packages:

  • React Native
  • Firebase
  • Auth0
  • Wallet-connect

@MuckT MuckT requested a review from silasbw May 21, 2024 22:36
@MuckT MuckT added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit d35a51b May 22, 2024
16 checks passed
@MuckT MuckT deleted the tomm/prevent-renovate-major-upgrades branch May 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants