Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(points): add required request headers for trackPointsEvent call #5378

Merged
merged 7 commits into from May 16, 2024

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented May 2, 2024

Description

The missing headers were causing these calls to always fail.

Test plan

No more errors for /trackPointsEvent

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 93.62101% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 86.19%. Comparing base (6ce52a6) to head (a92e095).
Report is 28 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5378      +/-   ##
==========================================
+ Coverage   86.09%   86.19%   +0.10%     
==========================================
  Files         737      748      +11     
  Lines       30016    30474     +458     
  Branches     5143     5196      +53     
==========================================
+ Hits        25842    26268     +426     
- Misses       3947     3978      +31     
- Partials      227      228       +1     
Files Coverage Δ
src/abis/AavePoolV3.ts 100.00% <100.00%> (ø)
src/analytics/Events.tsx 100.00% <100.00%> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/components/NumberTicker.tsx 97.14% <100.00%> (+0.17%) ⬆️
src/dappsExplorer/TabDiscover.tsx 95.83% <100.00%> (-0.07%) ⬇️
src/earn/EarnCta.tsx 100.00% <100.00%> (ø)
src/earn/selectors.ts 100.00% <100.00%> (ø)
src/earn/slice.ts 100.00% <100.00%> (ø)
.../fiatExchanges/FiatExchangeCurrencyBottomSheet.tsx 88.37% <100.00%> (ø)
src/jumpstart/JumpstartEnterAmount.tsx 93.02% <100.00%> (ø)
... and 30 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce52a6...a92e095. Read the comment docs.

@kathaypacific kathaypacific added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit c49d3f5 May 16, 2024
16 checks passed
@kathaypacific kathaypacific deleted the kathy/fix-points-track branch May 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants