Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More help #111

Merged
merged 4 commits into from
Dec 20, 2019
Merged

More help #111

merged 4 commits into from
Dec 20, 2019

Conversation

akx
Copy link
Member

@akx akx commented Dec 16, 2019

No description provided.

@akx akx requested a review from a team December 16, 2019 09:20
@ghost ghost requested review from JuhaKiili and magdapoppins and removed request for a team December 16, 2019 09:20
@JuhaKiili
Copy link
Contributor

TESTO FAILO

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #111 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   84.21%   84.26%   +0.04%     
==========================================
  Files          98       98              
  Lines        3010     3012       +2     
  Branches      429      429              
==========================================
+ Hits         2535     2538       +3     
- Misses        327      328       +1     
+ Partials      148      146       -2
Impacted Files Coverage Δ
valohai_cli/commands/execution/outputs.py 67.46% <100%> (+0.8%) ⬆️
valohai_cli/cli.py 60% <100%> (ø) ⬆️
valohai_cli/commands/parcel.py 67.01% <100%> (ø) ⬆️
valohai_cli/commands/login.py 72.72% <100%> (ø) ⬆️
valohai_cli/commands/execution/run/utils.py 66.66% <0%> (ø) ⬆️
valohai_cli/tui.py 94.82% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b47578...ebb4174. Read the comment docs.

@akx
Copy link
Member Author

akx commented Dec 19, 2019

TESTO FAILO

Not anymore. I think this was tangentially related to pytest-dev/pytest-cov#337 ...

Copy link
Contributor

@JuhaKiili JuhaKiili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be an automated test instead of a manual util script?

@akx
Copy link
Member Author

akx commented Dec 20, 2019

Could this be an automated test instead of a manual util script?

Could well add this to the CI flow, sure. :)

@akx akx merged commit 6cb6dda into master Dec 20, 2019
@akx akx deleted the more-help branch January 15, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants