Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add France oversea department phone codes #886

Closed
wants to merge 1 commit into from

Conversation

kbouzidi
Copy link

France has five administered territories outside the European continent. These territories have specific phone code but still can be assimilated to France number.
Guadeloupe->fr-GP->PhoneCode (590)
French Guiana->fr-GF->PhoneCode (594)
Martinique ->fr-MQ->PhoneCode (596)
Réunion ->fr-RE->PhoneCode (262)
Mayotte ->fr-YT->PhoneCode (262)

PS. As you may notice, reunion and Mayotte have the same Phone code, I choose to add only Réunion to avoid code duplication

@chriso
Copy link
Collaborator

chriso commented Aug 25, 2018

Thanks. Do you mind updating the source file and README?

@profnandaa
Copy link
Member

profnandaa commented Sep 2, 2018

@kbouzidi - as for fr-RE and fr-YT, you could add fr-YT as an alias after the other aliases here:

https://github.com/chriso/validator.js/blob/master/src/lib/isMobilePhone.js#L74-L76

phones['fr-YT'] = phones['fr-RE'];

Then add the tests and update the README as advised.

Let me know if you need any help 👍

@profnandaa
Copy link
Member

Ping @kbouzidi

@profnandaa profnandaa added 🧹 needs-update For PRs that need to be updated before landing help needed labels Sep 24, 2018
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Jul 9, 2019
- Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Close validatorjs#886
@profnandaa
Copy link
Member

closed in #1060

@profnandaa profnandaa closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help needed 🧹 needs-update For PRs that need to be updated before landing stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants