Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Spanish VAT number for foreigners #2375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Spanish VAT number for foreigners #2375

wants to merge 1 commit into from

Conversation

jvanveen
Copy link

This allows Spanish VAT numbers to have the following formats:

  • ES12345678 (spanish people)
  • ESX2345678X (foreigners)
  • ESX23456789 (foreigners)

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@jvanveen
fix: Spanish VAT number for foreigners
f02a6f4 
This allows Spanish VAT numbers to have the following formats:
* ES12345678 (spanish people)
* ESX2345678X (foreigners)
* ESX23456789 (foreigners)
WikiRik
WikiRik suggested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the new format and provide a source for the updated regular expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvanveen @WikiRik