Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added the mobile number validator for MARSHALL ISLANDS #2365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

poswalsameer
Copy link

This PR adds the country code with the regex mobile number validator for the country MARSHALL ISLANDS.

Fixes #1761

New country added at Line 125

Screenshot (193)

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (dcfbe14) 99.95%.

❗ Current head dcfbe14 differs from pull request most recent head 7a0688d. Consider uploading reports for the commit 7a0688d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poswalsameer
Copy link
Author

hello @ezkemboi sir, this is my first time contributing to any project. I have added the Marshall Islands to the list and created a PR. I have passed all test but need 2 reviews before merging of this pull request.

@ezkemboi
Copy link
Member

Please add tests.
Also, it seems, there are more to do, update the readme.

@ezkemboi
Copy link
Member

@poswalsameer can you check on the changes I made on this PR while back #1558
Can give you ideas of items you need to add.
Thanks for the PR

@poswalsameer
Copy link
Author

@poswalsameer can you check on the changes I made on this PR while back #1558 Can give you ideas of items you need to add. Thanks for the PR

sure sir, will check that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Phone validations - For The First Time Contributors
2 participants