feat(isMobilePhone): add validation for Kyrgyzstan [ky-KG] mobile phone numbers #2350
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
==========================================
- Hits 2453 2448 -5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
| @@ -118,7 +118,7 @@ const phones = { | |||
| 'kk-KZ': /^(\+?7|8)?7\d{9}$/, | |||
| 'kl-GL': /^(\+?299)?\s?\d{2}\s?\d{2}\s?\d{2}$/, | |||
| 'ko-KR': /^((\+?82)[ \-]?)?0?1([0|1|6|7|8|9]{1})[ \-]?\d{3,4}[ \-]?\d{4}$/, | |||
| 'ky-KG': /^(\+?7\s?\+?7|0)\s?\d{2}\s?\d{3}\s?\d{4}$/, | |||
| 'ky-KG': /^(\+996\s?)?(22[0-9]|50[0-9]|55[0-9]|70[0-9]|75[0-9]|77[0-9]|880|990|995|996|997|998)\s?\d{3}\s?\d{3}$/, | |||
There was a problem hiding this comment.
Upon quick comparison with the latest PDF of the ITU ( https://www.itu.int/oth/T0202000074/en ), I notice some missing mobile phone numbers. For example the relatively new +996 60 0 XXX XXX is missing, but also phone numbers from Table 3 (pages 7 and 8). Could you go through that document and update the regular expression accordingly?
There was a problem hiding this comment.
Yes, I can, but the information in the document is not up-to-date.
The numbers +996 60 0 XXX XXX are not used by the mobile operator beeline.kg (Sky Mobile LLC). You can check the list of all available codes here - https://nomer.beeline.kg/#/
As for the numbers on pages 7 and 8, the mobile operators (Aktel, Katel) no longer provide their services.
I found this information, but it's on Russian language.
There was a problem hiding this comment.
Certainly, here is the additional information:
+996 56X XXXXXX - Mobile - Winline (Sapatcom) - The operator is not operational.
+996 57X XXXXXX - Mobile - Sotel (Nexi) - The operator is not operational.
There was a problem hiding this comment.
These companies went bankrupt and closed even before the pandemic. : )
There was a problem hiding this comment.
@WikiRik hello!
I wanted to follow up on my previous comment from 5 days ago. I'm looking forward to hearing your response. If you have any questions or need further clarification, please feel free to ask.
Thank you in advance for your attention.
I have updated the regular expression used for validating mobile phone numbers in the Kyrgyzstan Republic.
I have used the following references to structure the updated regular expression:
Checklist