Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isVAT): improved ABN (AU GST/VAT ID) validation #2343

Merged
merged 1 commit into from Apr 27, 2024

Conversation

matthewberryman
Copy link
Contributor

@matthewberryman matthewberryman commented Dec 8, 2023

Implemented correct ABN (AU GST/VAT ID) validation per the official reference (see also this reference and implementation)

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated: N/A
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (730fbcc) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2343   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2459    +5     
  Branches      619      621    +2     
=======================================
+ Hits         2453     2458    +5     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewberryman matthewberryman changed the title improved ABN (AU VAT) validation feat(isVAT): improved ABN (AU GST/VAT ID) validation Dec 8, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib!

@profnandaa profnandaa merged commit 83d6ffd into validatorjs:master Apr 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants