Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(isIdentityCard): fix listed locales #2340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

breadadams
Copy link

Removed the MZ locale from the list of allowed locales for isIdentityCard, since a validation method has never been added for said locale.

It was added in #1604, presumably by mistake.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (700ded3) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik
Copy link
Member

WikiRik commented Nov 20, 2023

Don't mind the failure of codecov/project. That is not due to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants