Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitelist host to isEmail validation. #1920

Merged
merged 2 commits into from Oct 17, 2022
Merged

Add whitelist host to isEmail validation. #1920

merged 2 commits into from Oct 17, 2022

Conversation

poor-cooder
Copy link
Contributor

@poor-cooder poor-cooder commented Jan 31, 2022 •
edited

Add host whitelist to is Email validation.
closes: #1912

Add a new option (whitelist host) to isEmail options to check if the email domain is in it or not, if it was not in the whitelist host it fails.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited

Codecov Report

Merging #1920 (6353545) into master (cfcf911) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1920   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2099    +2     
  Branches       473       474    +1     
=========================================
+ Hits          2097      2099    +2
Impacted Files Coverage Δ
src/lib/isEmail.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...6353545. Read the comment docs.

profnandaa
profnandaa approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib 🎉

// And sorry for the delay in reviewing this.

@profnandaa profnandaa added 🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. labels Apr 22, 2022
@profnandaa
Copy link
Member

Just fix the m/c on README and we should be good to go.

@profnandaa profnandaa mentioned this pull request Apr 22, 2022
Closed
3 tasks
@poor-cooder
Copy link
Contributor Author

poor-cooder commented Apr 28, 2022 •
edited

Just fix the m/c on README and we should be good to go.

Hi, Thank you. The conflict has been fixed! 🚀

@SpiffGreen
Copy link

Can this be merged and closed now?

@rubiin rubiin added ready-to-land For PRs that are reviewed and ready to be landed ✅ LGTM and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jul 31, 2022
@profnandaa profnandaa merged commit c1d1b48 into validatorjs:master Oct 17, 2022
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🎉 first-pr ✅ LGTM ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isEmail add host_whitelist option
4 participants
@poor-cooder @profnandaa @SpiffGreen @rubiin