Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add Turkmenistan tk-TM #1780

Closed
wants to merge 5 commits into from

Conversation

husan-eshonqulov
Copy link
Contributor

@husan-eshonqulov husan-eshonqulov commented Oct 12, 2021

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1780 (d0a3a14) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1780   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...d0a3a14. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @husan-eshonqulov ! LGTM 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted 🎉 first-pr labels Oct 21, 2021
@profnandaa
Copy link
Member

@husan-eshonqulov -- pls fix the merge conflict on README and we should be good.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa profnandaa changed the title feat: (isMobilePhone) Add mobile phone validation for Turkmenistan (tk-TM) feat(isMobilePhone): add Turkmenistan tk-TM Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
@profnandaa
Copy link
Member

Your commits are now squashed here #1851, thanks!

@profnandaa profnandaa closed this Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
squashed commits and resolved merge conflict for #1780

Add Turkmenistan validation regax

Update README.md to include Turkmenistan (tk-Tm)

Add test cases for tk-TM

add missing comma for isMobilePhone.js

add missing commas for test/validators.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants