Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isMagnetURI): update validation regex #1730

Merged
merged 3 commits into from Sep 21, 2021
Merged

fix(isMagnetURI): update validation regex #1730

merged 3 commits into from Sep 21, 2021

Commits on Sep 20, 2021

  1. fix(isMagnetURI): update validation regex 

    - Validate only exact xn topics (btih,sha1,...)
- Validate only 32 or 40 hashes
- Make tr and dn parameters optional
- Allow any other parameter (protocol allow passing non standard parameters)
- Use placeholder hashes in tests 
- Fix ReDOS in old regex
- Add new tests
    @tux-tn
    tux-tn committed Sep 20, 2021
    Copy the full SHA
    e263b32 View commit details
    Browse the repository at this point in the history

  2. fix(isMagnetURI): prevent matching hashes longer than 40 characters

    @tux-tn
    tux-tn committed Sep 20, 2021
    Copy the full SHA
    3c4157a View commit details
    Browse the repository at this point in the history

  3. fix(isMagnetURI): check only string ending after hash or new paramete… 

    …r start
    @tux-tn
    tux-tn committed Sep 20, 2021
    Copy the full SHA
    90a51c2 View commit details
    Browse the repository at this point in the history