New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(niceToHave): Export list of country codes that implement IBAN #1669
Merged
profnandaa
merged 5 commits into
validatorjs:master
from
drorheller:feat/issues-1570-export-list-iban-countries
Jul 16, 2021
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
827b423
feat(niceToHave): Export list of country codes that implement IBAN
drorHellerNielsen 590cf79
Update src/index.js
drorheller d950276
fix(bug): Export isIBANLocales by its correct alias
drorHellerNielsen 7123c94
fix(test): fix name change in test
drorHellerNielsen 6006307
fix(standards): change members exported name
drorHellerNielsen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -5,6 +5,7 @@ import { locales as isAlphaLocales } from '../src/lib/isAlpha'; | |||||
import { locales as isAlphanumericLocales } from '../src/lib/isAlphanumeric'; | ||||||
import { locales as isMobilePhoneLocales } from '../src/lib/isMobilePhone'; | ||||||
import { locales as isFloatLocales } from '../src/lib/isFloat'; | ||||||
import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I would name it |
||||||
|
||||||
describe('Exports', () => { | ||||||
it('should export validators', () => { | ||||||
|
@@ -50,4 +51,9 @@ describe('Exports', () => { | |||||
assert.ok(isFloatLocales instanceof Array); | ||||||
assert.ok(validator.isFloatLocales instanceof Array); | ||||||
}); | ||||||
|
||||||
it('should export a list of country codes that implement IBAN', () => { | ||||||
assert.ok(ibanCountryCodes instanceof Array); | ||||||
assert.ok(validator.ibanCountryCodes instanceof Array); | ||||||
}); | ||||||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be calling them
isIBANLocales
could be a little misleading, might think it's a validator/function. Perhaps just drop theis
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profnandaa I see what you're saying, but I think it's more inline with the rest of the code to call it
isIBANLocales