fix(isIBAN): only strip spaces and hyphens before validating IBAN

[GoMino]

It turns out the IBAN validation is not working correctly as commented here #951 (comment)

The following function in isIBAN.js seems buggy:

function hasValidIbanFormat(str) {
  // Strip white spaces and hyphens, keep only digits and A-Z latin alphabetic
  const strippedStr = str.replace(/[^A-Z0-9]+/gi, '').toUpperCase();
  const isoCountryCode = strippedStr.slice(0, 2).toUpperCase();

  return (isoCountryCode in ibanRegexThroughCountryCode) &&
      ibanRegexThroughCountryCode[isoCountryCode].test(strippedStr);
}

We should not keep only digits and A-Z latin alphabetic, because any special char will be stripped away as well. We only want to strip spaces and hyphens.

Indeed we want the following IBANs to be INVALID:

• FR7630006000011234567890189@
• 'FR7630006000011234567890189😅
• FR763000600001123456!!🤨7890189@

This PR fix the issue

[profnandaa]

Thanks @GoMino for your contribution! Could you please clean up your diff, so that it just remains with only changes related isIBAN?

[GoMino]

@profnandaa I have just updated my pull request.

It wasn't clear to me why the build artefacts was not added to .gitignore (#1143 (comment)).

I would really appreciate if you could publish a new version of the library once this pull request get merged as we are using this library in one of our project right now.

Thanks for you great work by the way!

[GoMino]

Thanks for merging!

could you tell me when you plan to publish a new release ?

[GoMino]

@profnandaa, @ezkemboi is it possible to publish a new version of the library, which will include those changes ?

[profnandaa]

@GoMino -- sure, let me check with @chriso; we should be having enough stuff for release now.

[chriso]

@profnandaa @GoMino done!