Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean PR 1014 relating to fixing BR postal Code #1082

Merged
merged 3 commits into from Aug 12, 2019
Merged

Clean PR 1014 relating to fixing BR postal Code #1082

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
093933c
Added BR Validation
bloodf Apr 11, 2019
1be6b83
Lint Fix
bloodf Apr 11, 2019
6333c94
fix(clean): clean work on BR postal code
ezkemboi Aug 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/validators.js
View file
Open in desktop
Expand Up @@ -6719,6 +6719,14 @@ describe('Validators', () => {
'22040-020',
'39400-152',
],
invalid: [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made sure that I added tests for invalid cases. Just for safety.

Cc. @profnandaa.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

'79800A12',
'13165-00',
'38175-abc',
'81470-2763',
'78908',
'13010|111',
],
},
{
locale: 'NZ',
Expand Down